This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Improve Markdown rendering#47074
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This tweaks the new markdown renderer/sanitizer to allow more multimedia HTML like we use in our README and GitHub supports too.
Specifically:
<picture>for dark/light mode variations of images (this fixes our README reacting to light/dark theme)<picture>I reported and was promptly fixed, so this PR also updates the version to include itNone of these allow to execute JS so should be all safe.
Test plan
Tested manually on our README