Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

Fix single child expansion for new directory list#46628

Merged
philipp-spiess merged 2 commits into
mainfrom
ps/fix-single-child-expansion-in-directory-view
Jan 18, 2023
Merged

Fix single child expansion for new directory list#46628
philipp-spiess merged 2 commits into
mainfrom
ps/fix-single-child-expansion-in-directory-view

Conversation

@philipp-spiess

@philipp-spiess philipp-spiess commented Jan 18, 2023

Copy link
Copy Markdown
Contributor

This fixes single child directories in the new tree list.

Here's the current state, for reference: https://sourcegraph.com/github.com/sourcegraph/sourcegraph/-/tree/client/jetbrains/src/main/java

Test plan

Screenshot 2023-01-18 at 12 58 27

App preview:

Check out the client app preview documentation to learn more.

@philipp-spiess philipp-spiess requested review from a team and beyang January 18, 2023 12:04
@philipp-spiess philipp-spiess self-assigned this Jan 18, 2023
@cla-bot cla-bot Bot added the cla-signed label Jan 18, 2023
@github-actions github-actions Bot added the team/code-exploration Issues owned by the Code Exploration team label Jan 18, 2023
@sg-e2e-regression-test-bob

sg-e2e-regression-test-bob commented Jan 18, 2023

Copy link
Copy Markdown

Bundle size report 📦

Initial size Total size Async size Modules
0.00% (0.00 kb) 0.00% (+0.29 kb) 0.00% (+0.29 kb) 0.00% (0)

Look at the Statoscope report for a full comparison between the commits 21aab85 and 4df842d or learn more.

Open explanation
  • Initial size is the size of the initial bundle (the one that is loaded when you open the page)
  • Total size is the size of the initial bundle + all the async loaded chunks
  • Async size is the size of all the async loaded chunks
  • Modules is the number of modules in the initial bundle

@philipp-spiess philipp-spiess merged commit c392c8d into main Jan 18, 2023
@philipp-spiess philipp-spiess deleted the ps/fix-single-child-expansion-in-directory-view branch January 18, 2023 17:43
@beyang

beyang commented Jan 18, 2023

Copy link
Copy Markdown
Member

Thanks for the improvement!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed team/code-exploration Issues owned by the Code Exploration team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants