This repository was archived by the owner on Sep 30, 2024. It is now read-only.
insights: put data retention under an experimental setting for 4.4#46440
Merged
Conversation
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff dd141be...a299d8d.
|
coury-clark
reviewed
Jan 13, 2023
coury-clark
reviewed
Jan 13, 2023
|
|
||
| func (h *dataRetentionHandler) Handle(ctx context.Context, logger log.Logger, record *DataRetentionJob) (err error) { | ||
| doArchive := conf.ExperimentalFeatures().InsightsDataRetention | ||
| if doArchive != nil && !*doArchive { |
Contributor
There was a problem hiding this comment.
If you add the nil condition here you can safely remove the routine loading condition.
added 2 commits
January 13, 2023 18:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
flagging this until 4.5 when the exporting functionality will be competed
Test plan
started sourcegraph with and without the setting