Bundle size report 📦

Look at the Statoscope report for a full comparison between the commits 61342ec and bc67068 or learn more.

I'll try to see if I can find fitting icons that are monochrome and have less details for the top bar so that the UI is more consistent. We have a bunch of different editor icons though so I’m a bit worried about that 😅

I'll try to see if I can find fitting icons that are monochrome and have less details for the top bar so that the UI is more consistent. We have a bunch of different editor icons though so I’m a bit worried about that 😅

That'd be a nice touch, but I'd leave it for a designer, as it's 95% design work and 5% replacing the files and creating a PR. Also, it seems low prio, and I wouldn't bother for now.

That'd be a nice touch, but I'd leave it for a designer, as it's 95% design work and 5% replacing the files and creating a PR. Also, it seems low prio, and I wouldn't bother for now.

Hm maybe, but:

1. The current way of loading these images via the <img> tag should probably changed as well since it causes the images to be loaded last on the page which creates a noticeable lag

2. We don't really have enough design resources to help with this at the moment :/

On the other hand though, I can't find monochrome icons for these editors anyway 😅

I've changed the icon to "set up your IDE" only for now since this had the most color variance and is also visible to anyone that has not configured anything. It'll now load faster (since it's bundled in the JS) and look more coherent.

Before

After

Open question

I’m unsure what to do about the IDE icons. There are quite a few we support (see complete list) plus especially the JetBrains icons have no low-resolution version: https://www.jetbrains.com/company/brand/#logos-and-icons. The MDI icon set only really has an icon for VS Code (which we could use but then there's inconsistencies if you have another IDE configured at the same time.

I think we should probably not change the editor icons just yet and fix this up later.

cc @sourcegraph/design @sourcegraph/code-exploration

Regarding the IDE icons: I don't think there is much we can do, so I would use the coloured version for now. Even if they don't downscale well, they are still recognisable, even if not pixel perfect. I think that is better than having a monochrome version that the user doesn't identify.

❌ Problem: the label i-acknowledge-this-goes-into-the-release is absent.
👉 What to do: we're in the next Sourcegraph release code freeze period. If you are 100% sure your changes should get released or provide no risk to the release, add the label your PR with i-acknowledge-this-goes-into-the-release.

I'd suggest that we change the current "open in editor" icon (when no editor is set). The current icon shows code, which doesn't really explain that it's to open it in your editor. Sourcegraph and GitHub all equally show code.

I'd suggest application-edit-outline from MDI, which shows a desktop application with a pencil to indicate that it's an editor.

I think there is an argument for keeping the actual editor icons as they are, given they are brand logos (although it's a bit inconsistent that they are in color).

But I think we also should change the Blame icon, because currently it only signifies git, which could mean a number of things that are not blame (also, what does that mean on a Perforce repo?). It also indicates the active/disabled state only through color, which is a) not WCAG compliant and b) inconsistent with other buttons like raw Markdown mode or line break. Maybe one of these could work because they signify that it's about the authors that have touched the file:

(account-details, account-group, account-edit)

Yeah agree regarding the open-in-editor setup icon.

For git blame I think this one would work well. I agree regarding the color not be enough so I took a look at what git lense is doing in vscode and they have one icon that has an outlined and a filled style. Turns out that the icon that I liked best from your suggestions (account-details since it also shows lines) also has two variants in MDI, so I'd propose we go with these? (Will push a PR tomorrow morning)