This repository was archived by the owner on Sep 30, 2024. It is now read-only.
web: add code host details page.#46327
Merged
Merged
Conversation
Bundle size report 📦
Look at the Statoscope report for a full comparison between the commits 30ea7fa and ad78058 or learn more. Open explanation
|
Member
|
Great stuff! Awesome improvements :) |
Contributor
Author
Thanks :) Currently, the test is implemented as a "ping" thing, not an API call. I think it is planned to make it a real API call some time in future. |
mrnugget
approved these changes
Jan 11, 2023
mrnugget
approved these changes
Jan 11, 2023
This commit pretty much touches all code host related pages: - Adds redirects to details page after creating/updating a code host - Adds links to details page from code host list page - Removes connection check from code host list page - Removes sync jobs list from update code host page - New details page contains code host name and kind, number of synced repos (with a link to /repositories page), code host configuration and sync jobs. Also, it contains buttons for connection check and code host update/deletion. Test plan: Local sg run and manual tests with a full code host lifecycle checks, storybook.
…date repo number after sync is completed
1a7ecc3 to
30ea7fa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit pretty much touches all code host related pages:
Test plan:
Local sg run and manual tests with a full code host lifecycle checks, storybook.
THORSTEN, YOU CANNOT MISS IT
externalServiceDetailsPageDemo.mp4
Closes https://github.com/sourcegraph/sourcegraph/issues/46033