This repository was archived by the owner on Sep 30, 2024. It is now read-only.
codeintel: bring audit logs upload_size type in-line with lsif_uploads table#46209
Merged
Conversation
Contributor
|
I've saved an archive locally with all the data from the Chromium build and deleted the instance (it costs like $50/day); we can retry the upload after this patch lands on Sourcegraph.com |
1a11aa1 to
01d00bf
Compare
efritz
approved these changes
Jan 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was causing an
ERROR: integer out of range (SQLSTATE 22003)error that we thought originated from thelsif_uploadstable, but turns out it was from within the trigger. This wouldve been made more obvious if our errors had more info, see the output frompsql:The down migration may cause issues if there are entries that exceed
integersize, is this ok? @efritzTest plan
Ran it locally and it solved the issue