Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

github: ignore null JSON objects returned from GitHub API when listing public repositories.#45969

Merged
sashaostrikov merged 2 commits into
mainfrom
ao/fix-null-gh-repos
Dec 26, 2022
Merged

github: ignore null JSON objects returned from GitHub API when listing public repositories.#45969
sashaostrikov merged 2 commits into
mainfrom
ao/fix-null-gh-repos

Conversation

@sashaostrikov

Copy link
Copy Markdown
Contributor

Test plan:
Unit test added.

Co-authored-by: Indradhanush Gupta indradhanush.gupta@gmail.com

Part of https://github.com/sourcegraph/customer/issues/1688

…g public repositories.

Test plan:
Unit test added.

Co-authored-by: Indradhanush Gupta <indradhanush.gupta@gmail.com>

@indradhanush indradhanush left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We paired on it.

@sourcegraph-bot

sourcegraph-bot commented Dec 26, 2022

Copy link
Copy Markdown
Contributor

Codenotify: Notifying subscribers in CODENOTIFY files for diff 821918c...1a2c683.

Notify File(s)
@eseliger internal/extsvc/github/v3.go
internal/extsvc/github/v3_test.go

@indradhanush indradhanush added bug An error, flaw or fault that produces an incorrect or unexpected result, or behavior. github Issues that occur with GitHub as code host labels Dec 26, 2022
@burmudar

Copy link
Copy Markdown
Contributor

What an annoying bug! Thanks guys 👏

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug An error, flaw or fault that produces an incorrect or unexpected result, or behavior. cla-signed github Issues that occur with GitHub as code host

Projects

Status: ✅ Done - Released (available to install)

Development

Successfully merging this pull request may close these issues.

5 participants