This repository was archived by the owner on Sep 30, 2024. It is now read-only.
monitoring: zoekt.go - add p99/90/75 charts for search request duration#45966
Merged
Conversation
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 6f0b9e9...17fcb8c.
|
gl-srgr
approved these changes
Jan 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the following search request oriented dashboards to Zoekt (following the insights we learned from the Every Computer Performance Book):
p99/p90/p70 search request duration
amount of "in-flight" search requests (both aggregated and per instance)
rate of growth of the amount of "in-flight" search requests (both aggregated and per instance)
See the highlighted part of the screenshot for an example of these dashboards in action.
Test plan
I created the above screenshot using
sg start monitoringwhile connected to dogfood's prometheus instance.