Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

monitoring: zoekt.go - add p99/90/75 charts for search request duration#45966

Merged
ggilmore merged 6 commits into
mainfrom
zoeket-search-request-duration
Jan 3, 2023
Merged

monitoring: zoekt.go - add p99/90/75 charts for search request duration#45966
ggilmore merged 6 commits into
mainfrom
zoeket-search-request-duration

Conversation

@ggilmore

@ggilmore ggilmore commented Dec 24, 2022

Copy link
Copy Markdown
Contributor

This PR adds the following search request oriented dashboards to Zoekt (following the insights we learned from the Every Computer Performance Book):

  1. p99/p90/p70 search request duration

    • Should be self-evident for why this is useful. This would have been helpful to have handy on a recent customer call.
  2. amount of "in-flight" search requests (both aggregated and per instance)

    • This dashboard serves as a proxy for the "workload" that zoekt-webserver is currently experiencing. Note, that there are multiple search/transaction types (interactive, versus batched), but I think treating all transactions as the same is a good first-pass as a workload meter. See this example of how the # of concurrent search request roughly correlates to the CPU usage:
      • Screen Shot 2022-12-23 at 4 42 49 PM
    • Here is a similar one with rate-of-growth of search request and CPU usage (notice how positivity/negativity corresponds with the swings in the cpu graph
    • Screen Shot 2022-12-23 at 4 45 54 PM
  3. rate of growth of the amount of "in-flight" search requests (both aggregated and per instance)

    • This is dashboard is just the derivative of the above dashboard. This dashboard helps to give an intuition about how "quickly" zoekt-webserver is grinding through its request load. It should hover pretty close to zero under normal circumstances.

See the highlighted part of the screenshot for an example of these dashboards in action.

screencapture-localhost-3370-debug-grafana-d-zoekt-zoekt-2022-12-23-16_10_47

Test plan

I created the above screenshot using sg start monitoring while connected to dogfood's prometheus instance.

@cla-bot cla-bot Bot added the cla-signed label Dec 24, 2022
@ggilmore ggilmore marked this pull request as ready for review December 24, 2022 00:48
@ggilmore ggilmore requested a review from a team December 24, 2022 00:48
@sourcegraph-bot

sourcegraph-bot commented Dec 24, 2022

Copy link
Copy Markdown
Contributor

Codenotify: Notifying subscribers in CODENOTIFY files for diff 6f0b9e9...17fcb8c.

Notify File(s)
@bobheadxi monitoring/definitions/zoekt.go
@slimsag monitoring/definitions/zoekt.go
@sourcegraph/delivery doc/admin/observability/dashboards.md
monitoring/definitions/zoekt.go

@ggilmore ggilmore enabled auto-merge (squash) January 3, 2023 15:42
@ggilmore ggilmore merged commit 82431e2 into main Jan 3, 2023
@ggilmore ggilmore deleted the zoeket-search-request-duration branch January 3, 2023 16:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants