This repository was archived by the owner on Sep 30, 2024. It is now read-only.
github.go: adjust organization not found error message to indicate that org was manually specified in configuration#45918
Merged
Merged
Conversation
…at org was specified in configuration
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 6988b62...613333d.
|
Contributor
Author
affects github.com and enterprise
indradhanush
approved these changes
Dec 22, 2022
indradhanush
left a comment
Contributor
There was a problem hiding this comment.
This is great! (Left a suggestion for a typo)
sashaostrikov
approved these changes
Dec 22, 2022
Co-authored-by: Indradhanush Gupta <indradhanush.gupta@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
background
One of our customers specifies a number of github organizations (100+) in the configuration for their github enterprise instance.
Example of their configuration:
{ "url": "https://ghe-scaletesting.sgdev.org", "token": "REDACTED", "orgs": [ "org-that-exists", // ... "non-existant", // <- this org was deleted // ... ] }Some of these organizations are periodically deleted / removed from their GHE instance. When this occurs, this is the error message they see on their code host configuration page:
To them, it's not obvious that the organization in this error message is one that they manually specified, as opposed to a transient error that occurred since the last time that Sourcegraph tried to sync. This led to further confusion as to why this error wasn't eventually resolving itself.
solution
This PR clarifies the wording of the error message to indicate the mentioned organization is specifically one that they specified in their configuration. Example:
Test plan
CI is sufficient (all this is doing is changing the wording of an error message)