This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Enable search results keyboard navigation by default#45890
Merged
novoselrok merged 3 commits intoDec 22, 2022
Conversation
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff b3fe0bc...696d417.
|
Bundle size report 📦
Look at the Statoscope report for a full comparison between the commits 696d417 and b3fe0bc or learn more. Open explanation
|
olafurpg
approved these changes
Dec 21, 2022
olafurpg
left a comment
Contributor
There was a problem hiding this comment.
LGTM 👍🏻 I noticed two issues that we can fix separately or in this PR.
- The search bar got auto-focused after opening a search result with
Entermaking it not possible to go back in browser history with Cmd+ArrowLeft - After going back in browser history from the blob page to the search results, the top result was focused when I expected the focused item to be persiste result I opened to be focused.
Contributor
Author
Yep, both issues are still in there from the original PR. I looked into it briefly, but there seems to be a deeper problem with search input focusing that I probably won't be able to fix in this PR. Will probably require a separate PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables search results keyboard navigation by default
Test plan
Use Arrow Up/Down keys to navigate between search results, Arrow Left/Right to collapse and expand file matches, Enter to open the search result in the current tab, Ctrl/Cmd+Enter to open the result in a separate tab, / to refocus the search input, and Ctrl/Cmd+Arrow Down to jump from the search input to the first result. Arrow Left/Down/Up/Right in previous examples can be substituted with h/j/k/l for Vim-style bindings.
App preview:
Check out the client app preview documentation to learn more.