migrations: Add column author_user_id to critical_and_site_config#45618
migrations: Add column author_user_id to critical_and_site_config#45618indradhanush wants to merge 3 commits into
Conversation
…itical_and_site_config/down.sql Co-authored-by: Alex Ostrikov <alex.ostrikov@sourcegraph.com>
mrnugget
left a comment
There was a problem hiding this comment.
Why add this column without the code that populates it? I'm a bit unclear on how we're going to use the column
I wanted to get this out and follow up with the PR that would use this column. The |
| @@ -0,0 +1,3 @@ | |||
|
|
|||
I get the need to keep changes small, but this is a ~25 line change that doesn't do anything, it only adds a dead column. I'm scared that once we start using it it turns out it needs to be non-nullable, or something like that, and then we need to redo the migration again. |
I forgot to reply to this. 😓 Makes sense. I'll close this PR for now and come back to it if I have some downtime between bigger issues. |
|
Just to express interests that there was a use case for this column in a recent MI debugging, I wanted to find out was it the customer admin or us made a mistake in one of the site config update. |
Thank you for the data point. I think its important to have that in place and hopefully can come back to make use of the migration soon this year. |
We recently had an incident where a site config was changed but didn't know who / why this was made.
Adding an
author_user_idto the table will help with auditing.We needed this feature as part of #40377 anyway.
Test plan
sg migration upandsg migration downto.sg startworks