Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

search contexts: set default from individual page#45391

Merged
limitedmage merged 1 commit into
jp/defaultcontextfrom
jp/defaultcontextindividual
Dec 8, 2022
Merged

search contexts: set default from individual page#45391
limitedmage merged 1 commit into
jp/defaultcontextfrom
jp/defaultcontextindividual

Conversation

@limitedmage

@limitedmage limitedmage commented Dec 7, 2022

Copy link
Copy Markdown
Contributor

Stacked on #45387

Part of #44903

  • "use as default" button shows on individual context pages when the context is not the default
  • All tags, including auto and default, are now shown in the individual context pages

image

image

image

Test plan

Test setting default works when connected and renders error when disconnected.

App preview:

Check out the client app preview documentation to learn more.

@limitedmage limitedmage requested review from a team, novoselrok and quinnkeast December 7, 2022 23:11
@cla-bot cla-bot Bot added the cla-signed label Dec 7, 2022
@sg-e2e-regression-test-bob

Copy link
Copy Markdown

Bundle size report 📦

Initial size Total size Async size Modules
0.00% (0.00 kb) 0.02% (+2.98 kb) 0.02% (+2.98 kb) 0.00% (0)

Look at the Statoscope report for a full comparison between the commits 8b74dce and 20238a4 or learn more.

Open explanation
  • Initial size is the size of the initial bundle (the one that is loaded when you open the page)
  • Total size is the size of the initial bundle + all the async loaded chunks
  • Async size is the size of all the async loaded chunks
  • Modules is the number of modules in the initial bundle

@limitedmage limitedmage merged commit ddfdb13 into jp/defaultcontext Dec 8, 2022
@limitedmage limitedmage deleted the jp/defaultcontextindividual branch December 8, 2022 16:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants