Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

insights: capture group and compute insights work when sub-repo perm setting is enabled#45361

Merged
leonore merged 8 commits into
mainfrom
insights/fix-sub-repo-perms
Dec 8, 2022
Merged

insights: capture group and compute insights work when sub-repo perm setting is enabled#45361
leonore merged 8 commits into
mainfrom
insights/fix-sub-repo-perms

Conversation

@leonore

@leonore leonore commented Dec 7, 2022

Copy link
Copy Markdown
Contributor

closes #45356

Any sub-repo permissions check errors will be collected and added on to the final error

Test plan

Enabled sub-repo permissions in site config. Before had no data, after it worked.

Screenshot 2022-12-07 at 17 38 17

Screenshot 2022-12-07 at 17 38 39

@leonore leonore requested a review from a team December 7, 2022 17:40
@cla-bot cla-bot Bot added the cla-signed label Dec 7, 2022
@sourcegraph-bot

sourcegraph-bot commented Dec 7, 2022

Copy link
Copy Markdown
Contributor

Codenotify: Notifying subscribers in CODENOTIFY files for diff b9a2844...67d1c56.

Notify File(s)
@sourcegraph/code-insights-backend enterprise/internal/insights/background/queryrunner/search.go
enterprise/internal/insights/background/queryrunner/search_test.go

Comment thread CHANGELOG.md Outdated
Co-authored-by: coury-clark <coury@sourcegraph.com>
@leonore leonore enabled auto-merge (squash) December 8, 2022 09:56
@leonore leonore disabled auto-merge December 8, 2022 14:19
@leonore leonore requested a review from chwarwick December 8, 2022 14:19
@leonore leonore enabled auto-merge (squash) December 8, 2022 14:25
@leonore leonore merged commit b844c94 into main Dec 8, 2022
@leonore leonore deleted the insights/fix-sub-repo-perms branch December 8, 2022 14:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

insights: capture group insights don't work when sub-repo permissions are enabled

4 participants