This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Exclude files in search.largeFiles#45318
Merged
Merged
Conversation
… to pattern to negate. Acknowledge escaped '!' as literal.
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 0cac134...c614a74.
|
gl-srgr
commented
Dec 7, 2022
| if strings.HasPrefix(pattern, negate) { | ||
| return true, pattern[len(negate):] | ||
| } | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Initially I would strip the escaped backslash here but doublestar handles that for us
keegancsmith
approved these changes
Dec 7, 2022
Member
|
Once this all lands, please add a changelog. I think branch cut is soonish, so try and land soon so customers get extra christmas presents :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The site config setting search.largeFiles should allow file exclusions so that known large files can be excluded from the index.
Zoekt PR: sourcegraph/zoekt#480
This PR introduces extra steps in filter for handling interpretation of largeFiles patterns. Although doublestar still handles parsing for us we now handle additional cases:
a pattern is prefixed by !: We use this character to define negation. Any file matching the pattern following the ! is treated as not being on the large files allow list, and is skipped (same as it would be if no pattern in the largeFiles patterns list matched the file). We honor the order of the patterns in the list. That is, if the file matches multiple patterns in the list then the latest entry is honored and it overrides whatever the preceding matches behavior would have been.
a pattern prefixed with an escape '': No interpretation of the ! so no negation is applied. for example: "\!file.txt" will allow us to not skip the file named "!file.txt".
GH Issue: https://github.com/sourcegraph/sourcegraph/issues/40688
Test plan