Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

Site admin repos: Add indexed filtering dropdown and count-by-status …#45288

Merged
cbart merged 7 commits into
mainfrom
cbart/39328-indexed-filtering-dropdown
Dec 8, 2022
Merged

Site admin repos: Add indexed filtering dropdown and count-by-status …#45288
cbart merged 7 commits into
mainfrom
cbart/39328-indexed-filtering-dropdown

Conversation

@cbart

@cbart cbart commented Dec 6, 2022

Copy link
Copy Markdown
Contributor

Closes #39328

In site admin > repositories page

  • There is a status dropdown that now gets a Indexed value which filters to show only indexed repositories
  • The count and legend of indexed repositories is clickable and triggers the filter mentioned above

See it in action:
https://www.loom.com/share/3b4c89066fd14dcf8a4e067499fa4394

Test plan

Manually tested and recorded a demo.

App preview:

Check out the client app preview documentation to learn more.

@cla-bot cla-bot Bot added the cla-signed label Dec 6, 2022
@cbart cbart marked this pull request as draft December 6, 2022 19:32
@sg-e2e-regression-test-bob

sg-e2e-regression-test-bob commented Dec 6, 2022

Copy link
Copy Markdown

Bundle size report 📦

Initial size Total size Async size Modules
0.00% (0.00 kb) 0.00% (+0.15 kb) 0.00% (+0.15 kb) 0.00% (0)

Look at the Statoscope report for a full comparison between the commits 2d30e93 and b297655 or learn more.

Open explanation
  • Initial size is the size of the initial bundle (the one that is loaded when you open the page)
  • Total size is the size of the initial bundle + all the async loaded chunks
  • Async size is the size of all the async loaded chunks
  • Modules is the number of modules in the initial bundle

@cbart cbart marked this pull request as ready for review December 6, 2022 20:45
@cbart

cbart commented Dec 6, 2022

Copy link
Copy Markdown
Contributor Author

Please let me know if there is any extra testing that is reasonable here. The component change feels minimal that existing UI unit tests are sufficient, while the back end is tested from graphQL down to the database.

@cbart cbart requested a review from a team December 6, 2022 20:46

@sashaostrikov sashaostrikov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ryanslade ryanslade left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Comment thread CHANGELOG.md Outdated
Co-authored-by: Thorsten Ball <mrnugget@gmail.com>
@cbart

cbart commented Dec 7, 2022

Copy link
Copy Markdown
Contributor Author

Thank you for the comments and suggestions!

@cbart cbart merged commit 0cac134 into main Dec 8, 2022
@cbart cbart deleted the cbart/39328-indexed-filtering-dropdown branch December 8, 2022 21:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Repository Status: Add counts to all filtered views and add "In progress" filters

5 participants