This repository was archived by the owner on Sep 30, 2024. It is now read-only.
use chunk matches over line matches for insights#44969
Merged
Merged
Conversation
…he case of sequential whitespace
chwarwick
approved these changes
Nov 30, 2022
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff fb2b15f...c9a33c8.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/sourcegraph/sourcegraph/issues/44965
This solves a bug where multiple whitespaces in a sequence would produce too many line matches. It seems we just missed the boat at some point when this became exposed in the API, so we would want to migrate anyway. The next step will be to retire this for the internal search client, but this solves the bug for now.
Test plan
Here is an example insight that demonstrated the overcounting bug before and after.