This repository was archived by the owner on Sep 30, 2024. It is now read-only.
batches: unify the naming convention of forks created from batch changes for github#44924
Merged
Conversation
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff a5d2797...7c87569.
|
Piszmog
approved these changes
Nov 30, 2022
courier-new
approved these changes
Dec 1, 2022
courier-new
left a comment
Contributor
There was a problem hiding this comment.
Code changes look good, but if this is the final code host I'd love to see the docs page updated alongside the CHANGELOG entry you added. 😄
Co-authored-by: Kelli Rockwell <kelli@sourcegraph.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #44547
As reported in https://github.com/sourcegraph/sourcegraph/issues/41641, when
batches.enforceForksis enabled by the user, the creation of forks would fails due to us currently not handling the case of repos that are not forks yet have the same name. This PR is to make all behaivor uniform, as Github would handle forks with incrementing numbers, instead we'll match the behavior previously implemented which creates forks in the following convention:usernamespace/parentnamespace-reponame
Test plan
manually tested the creation of forks for batch changes when a repo with the same name exists on the codehost as well as testing that when the fork exists, the user can create batch changes with a new branch name.