This repository was archived by the owner on Sep 30, 2024. It is now read-only.
search: fix human string representation for metachars in query#44917
Merged
Conversation
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff a01103d...e15634b.
|
8dc20f4 to
2b06bb8
Compare
Contributor
Author
|
@chwarwick could you check the changelog entry for accuracy? |
Contributor
Author
|
Need to fix other things this affects, will put up for review again when ready. |
2b06bb8 to
5703aae
Compare
Contributor
Change log looks good to me. |
Contributor
Author
|
Fixed up, ready for review |
camdencheek
approved these changes
Nov 29, 2022
5703aae to
35efa33
Compare
35efa33 to
e15634b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/sourcegraph/sourcegraph/issues/44738
A query containing special chars
(,)that are unbalanced needs to be quoted/escaped when generating a human representation, because these characters can break the meaning of a well-formed query with expressions.See also https://sourcegraph.slack.com/archives/C014ZCKMCAV/p1669114578350879
Test plan
Added test