Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

Revert "Revert "Log external requests (#44286)" (#44890)" aka reapply Log External Requests#44893

Merged
burmudar merged 1 commit into
mainfrom
wb+david/re-apply-log-external-requests
Nov 29, 2022
Merged

Revert "Revert "Log external requests (#44286)" (#44890)" aka reapply Log External Requests#44893
burmudar merged 1 commit into
mainfrom
wb+david/re-apply-log-external-requests

Conversation

@burmudar

@burmudar burmudar commented Nov 29, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

This reverts commit 8dc8fb0.

Which means we're effectly re-applying

Test plan

green ci

@burmudar burmudar requested review from a team and vdavid November 29, 2022 13:58
@burmudar burmudar self-assigned this Nov 29, 2022
@cla-bot cla-bot Bot added the cla-signed label Nov 29, 2022
@burmudar burmudar enabled auto-merge (squash) November 29, 2022 13:59
@sourcegraph-bot

sourcegraph-bot commented Nov 29, 2022

Copy link
Copy Markdown
Contributor

Codenotify: Notifying subscribers in CODENOTIFY files for diff f23468c...6bc9967.

Notify File(s)
@keegancsmith internal/httpcli/client.go
internal/httpcli/client_test.go
internal/httpcli/external.go
internal/httpcli/redis_logger_middleware.go
internal/httpcli/redis_logger_middleware_test.go

Closed
38 tasks
@sg-e2e-regression-test-bob

sg-e2e-regression-test-bob commented Nov 29, 2022

Copy link
Copy Markdown

Bundle size report 📦

Initial size Total size Async size Modules
0.01% (+0.31 kb) 0.11% (+16.33 kb) 🔺 0.13% (+16.02 kb) 🔺 0.14% (+1) 🔺

Look at the Statoscope report for a full comparison between the commits 6bc9967 and f23468c or learn more.

Open explanation
  • Initial size is the size of the initial bundle (the one that is loaded when you open the page)
  • Total size is the size of the initial bundle + all the async loaded chunks
  • Async size is the size of all the async loaded chunks
  • Modules is the number of modules in the initial bundle

@burmudar burmudar merged commit ca0d18a into main Nov 29, 2022
@burmudar burmudar deleted the wb+david/re-apply-log-external-requests branch November 29, 2022 14:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@vdavid vdavid vdavid approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@burmudar burmudar

Labels

cla-signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@burmudar @sourcegraph-bot @sg-e2e-regression-test-bob @vdavid