This repository was archived by the owner on Sep 30, 2024. It is now read-only.
insights: updating capture group insights metadata does not trigger recalculation#44797
Merged
Conversation
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff a49c8c8...a94ca1e.
|
chwarwick
approved these changes
Nov 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
part of #42116
while working on saving default filters I found that capture group insights were always getting recalculated regardless of the change because the frontend does not send series id data for capture group insights. it is however not trivial to add this series id information (we have 1 series per insight for capture group insights but return multiple dataseries with fabricated insights to the frontend). so the backend has to handle the case of capture group insights separately.
it is worth noting that sort & limit filters are still not getting saved, because of #42459
new behaviour: changing a capture group insight's filter or title will not trigger recalculation.
Test plan
Added an integration test and validated that the test failed against the latest insiders image, but succeeded on my local instance.