This repository was archived by the owner on Sep 30, 2024. It is now read-only.
insights: improve update insight flow #44769
Merged
Merged
Conversation
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff b4c9f4d...76b981c.
|
UpdateViewSeries call
chwarwick
reviewed
Nov 23, 2022
chwarwick
approved these changes
Nov 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
part of #42116
previously, in the update insight mutation for existing insight series we
call 3 was completely redundant as the series was no longer in use. it would just affect 0 rows each time.
now, we check whether the series existed before. if it didn't we just create a new one. otherwise we check what has changed. if it's only presentation metadata we won't trigger an insight recalculation.
Test plan
Added an integration test and manually validated that before/after did not change when creating some insights
see it in action: https://www.loom.com/share/2b893d3691cd40df81a910e60bd42ab5
with
sg start enterprise-codeinsightsrunning: