Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

Add PageSwitcher wildcard component#44737

Merged
philipp-spiess merged 10 commits into
mainfrom
ps/add-page-switcher-wildcard-component
Nov 24, 2022
Merged

Add PageSwitcher wildcard component#44737
philipp-spiess merged 10 commits into
mainfrom
ps/add-page-switcher-wildcard-component

Conversation

@philipp-spiess

@philipp-spiess philipp-spiess commented Nov 22, 2022

Copy link
Copy Markdown
Contributor

Part of #44706

This adds a new <PageSwitcher /> (I’m open to better name suggestions, this one is derived from the proposal to call the hook usePageSwitcherPagination) component to the set of Wildcard components:

Screenshot 2022-11-23 at 14 33 05

Figma: https://www.figma.com/file/LZoW17Fy6eqOfnxjxIRB7d/%F0%9F%93%91-Pagination-Experiments?t=0QPBSel9sN03v8us-1

Test plan

App preview:

Check out the client app preview documentation to learn more.

@cla-bot cla-bot Bot added the cla-signed label Nov 22, 2022
@github-actions github-actions Bot added the team/code-exploration Issues owned by the Code Exploration team label Nov 22, 2022
@sg-e2e-regression-test-bob

sg-e2e-regression-test-bob commented Nov 22, 2022

Copy link
Copy Markdown

Bundle size report 📦

Initial size Total size Async size Modules
0.00% (0.00 kb) 0.00% (0.00 kb) 0.00% (0.00 kb) 0.00% (0)

Look at the Statoscope report for a full comparison between the commits 0ff0e0d and 9659e7c or learn more.

Open explanation
  • Initial size is the size of the initial bundle (the one that is loaded when you open the page)
  • Total size is the size of the initial bundle + all the async loaded chunks
  • Async size is the size of all the async loaded chunks
  • Modules is the number of modules in the initial bundle

@philipp-spiess philipp-spiess marked this pull request as ready for review November 23, 2022 11:41
@philipp-spiess philipp-spiess force-pushed the ps/add-page-switcher-wildcard-component branch from 2fea528 to a77c675 Compare November 23, 2022 11:42
@sourcegraph-bot

sourcegraph-bot commented Nov 23, 2022

Copy link
Copy Markdown
Contributor

Codenotify: Notifying subscribers in OWNERS files for diff cb5774d...0ff0e0d.

Notify File(s)
@sourcegraph/code-exploration-devs client/wildcard/src/components/PageSwitcher/PageSwitcher.module.scss
client/wildcard/src/components/PageSwitcher/PageSwitcher.story.tsx
client/wildcard/src/components/PageSwitcher/PageSwitcher.test.tsx
client/wildcard/src/components/PageSwitcher/PageSwitcher.tsx
client/wildcard/src/components/PageSwitcher/index.tsx
@vovakulikov client/wildcard/src/components/PageSwitcher/PageSwitcher.module.scss
client/wildcard/src/components/PageSwitcher/PageSwitcher.story.tsx
client/wildcard/src/components/PageSwitcher/PageSwitcher.test.tsx
client/wildcard/src/components/PageSwitcher/PageSwitcher.tsx
client/wildcard/src/components/PageSwitcher/index.tsx

@danielmarquespt danielmarquespt self-requested a review November 23, 2022 13:32

@danielmarquespt danielmarquespt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Design has reviewed and its approved

@philipp-spiess philipp-spiess self-assigned this Nov 23, 2022
@philipp-spiess philipp-spiess force-pushed the ps/add-page-switcher-wildcard-component branch from 752373a to 0ff0e0d Compare November 23, 2022 15:00

@eseliger eseliger left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@philipp-spiess philipp-spiess merged commit 8d86d5c into main Nov 24, 2022
@philipp-spiess philipp-spiess deleted the ps/add-page-switcher-wildcard-component branch November 24, 2022 11:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed team/code-exploration Issues owned by the Code Exploration team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants