Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

batches: Show all Bulk Operations (but disable unavailable operations )#44617

Merged
BolajiOlajide merged 7 commits into
mainfrom
bo/show-all-bulk-actions-always
Nov 28, 2022
Merged

batches: Show all Bulk Operations (but disable unavailable operations )#44617
BolajiOlajide merged 7 commits into
mainfrom
bo/show-all-bulk-actions-always

Conversation

@BolajiOlajide

@BolajiOlajide BolajiOlajide commented Nov 18, 2022

Copy link
Copy Markdown
Contributor

Closes #44017

Before After
CleanShot 2022-11-18 at 18 50 06@2x CleanShot 2022-11-18 at 18 22 05@2x

Test plan

Ensure all appropriate bulk operations are displayed when changeset(s) are selected, and the available for each changeset is enabled.

App preview:

Check out the client app preview documentation to learn more.

Updated the storybook to reflect this change.

@BolajiOlajide BolajiOlajide added the batch-changes Issues related to Batch Changes label Nov 18, 2022
@BolajiOlajide BolajiOlajide self-assigned this Nov 18, 2022
@cla-bot cla-bot Bot added the cla-signed label Nov 18, 2022
@sg-e2e-regression-test-bob

sg-e2e-regression-test-bob commented Nov 18, 2022

Copy link
Copy Markdown

Bundle size report 📦

Initial size Total size Async size Modules
0.00% (0.00 kb) 0.00% (+0.04 kb) 0.00% (+0.04 kb) 0.00% (0)

Look at the Statoscope report for a full comparison between the commits ecf5aec and d43fb3f or learn more.

Open explanation
  • Initial size is the size of the initial bundle (the one that is loaded when you open the page)
  • Total size is the size of the initial bundle + all the async loaded chunks
  • Async size is the size of all the async loaded chunks
  • Modules is the number of modules in the initial bundle

@BolajiOlajide BolajiOlajide marked this pull request as ready for review November 18, 2022 19:13
@sourcegraph-bot

sourcegraph-bot commented Nov 18, 2022

Copy link
Copy Markdown
Contributor

Codenotify: Notifying subscribers in CODENOTIFY files for diff d43fb3f...ecf5aec.

Notify File(s)
@courier-new client/web/src/enterprise/batches/detail/changesets/ChangesetSelectRow.story.tsx
client/web/src/enterprise/batches/detail/changesets/ChangesetSelectRow.tsx
@eseliger client/web/src/enterprise/batches/detail/changesets/ChangesetSelectRow.story.tsx
client/web/src/enterprise/batches/detail/changesets/ChangesetSelectRow.tsx

@BolajiOlajide BolajiOlajide requested a review from a team November 18, 2022 19:18
@BolajiOlajide BolajiOlajide merged commit 4cfc15f into main Nov 28, 2022
@BolajiOlajide BolajiOlajide deleted the bo/show-all-bulk-actions-always branch November 28, 2022 03:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

batch-changes Issues related to Batch Changes cla-signed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Show all Bulk Operations (but disable unavailable operations )

6 participants