Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

Add usePaginatedConnection#44574

Merged
0xnmn merged 4 commits into
naman/saved-searches-paginatefrom
ps/use-paginated-query
Nov 18, 2022
Merged

Add usePaginatedConnection#44574
0xnmn merged 4 commits into
naman/saved-searches-paginatefrom
ps/use-paginated-query

Conversation

@philipp-spiess

@philipp-spiess philipp-spiess commented Nov 17, 2022

Copy link
Copy Markdown
Contributor

Test plan

@cla-bot cla-bot Bot added the cla-signed label Nov 17, 2022
@github-actions github-actions Bot added the team/code-exploration Issues owned by the Code Exploration team label Nov 17, 2022
@philipp-spiess philipp-spiess changed the base branch from main to naman/saved-searches-paginate November 17, 2022 18:21
@sg-e2e-regression-test-bob

sg-e2e-regression-test-bob commented Nov 17, 2022 •
edited
Loading

Copy link
Copy Markdown

Bundle size report 📦

Initial size Total size Async size Modules
0.00% (+0.05 kb) -0.00% (-0.66 kb) -0.01% (-0.70 kb) 0.28% (+2) 🔺

Look at the Statoscope report for a full comparison between the commits 67ccda1 and a39ae21 or learn more.

Open explanation
  • Initial size is the size of the initial bundle (the one that is loaded when you open the page)
  • Total size is the size of the initial bundle + all the async loaded chunks
  • Async size is the size of all the async loaded chunks
  • Modules is the number of modules in the initial bundle

@philipp-spiess philipp-spiess mentioned this pull request Nov 18, 2022
Merged
@0xnmn 0xnmn marked this pull request as ready for review November 18, 2022 16:08
@0xnmn 0xnmn merged commit 86da8e4 into naman/saved-searches-paginate Nov 18, 2022
@0xnmn 0xnmn deleted the ps/use-paginated-query branch November 18, 2022 16:09
@sourcegraph-bot

sourcegraph-bot commented Nov 18, 2022

Copy link
Copy Markdown
Contributor

Codenotify: Notifying subscribers in CODENOTIFY files for diff f4a2335...4b82e3c.

Notify File(s)
@fkling client/web/src/search/backend.tsx
@limitedmage client/web/src/search/backend.tsx

@philipp-spiess philipp-spiess mentioned this pull request Nov 23, 2022
Closed
7 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@courier-new courier-new Awaiting requested review from courier-new

1 more reviewer

@0xnmn 0xnmn 0xnmn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla-signed team/code-exploration Issues owned by the Code Exploration team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@philipp-spiess @sg-e2e-regression-test-bob @sourcegraph-bot @0xnmn