This repository was archived by the owner on Sep 30, 2024. It is now read-only.
insights: update empty repo error handling in commit indexer#44558
Merged
Conversation
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff fb922dd...fae19bf.
|
chwarwick
reviewed
Nov 17, 2022
91b3a5c to
092a24e
Compare
chwarwick
approved these changes
Nov 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
while running tests on scaletesting found that we were erroring on empty repos again even though it should have been fixed by #38091. turns out sub repo permissions are enabled on the env and the git command changes in those cases.
tldr; account for
--name-onlyoptionTest plan
Added and updated unit tests