search: Enable search history button by default#44544
Conversation
This enables the search history by default. Inline history has already been enabled. This also reverts the change to hide the copy query button on the search homepage.
| onChange={props.setQueryState} | ||
| onSubmit={onSubmit} | ||
| autoFocus={!showSearchHistory && !isTouchOnlyDevice && props.autoFocus !== false} | ||
| autoFocus={!isTouchOnlyDevice && props.autoFocus !== false} |
There was a problem hiding this comment.
I believe this was actually a left over from the first search history experiment. The input should always be focused on the search home page.
There was a problem hiding this comment.
Yes, it's a leftover, and this change is correct—it should focus on load!
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff ba327d5...b3f127b.
|
Bundle size report 📦
Look at the Statoscope report for a full comparison between the commits b3f127b and ba327d5 or learn more. Open explanation
|
| applySuggestionsOnEnter={applySuggestionsOnEnter} | ||
| showCopyQueryButton={!showSearchHistory} | ||
| showSearchHistory={showSearchHistory} | ||
| showSearchHistory={true} |
There was a problem hiding this comment.
Should users be able to turn it off? I'm fine if it's permanently enabled. @quinnkeast
There was a problem hiding this comment.
At least for now, no—I'm of a mind we should avoid introducing additional complexity given we'll likely do larger more holistic changes to the search input.
limitedmage
left a comment
There was a problem hiding this comment.
Nice! Can we remove the feature flag from the typings?
This enables the search history by default. Inline history has already been enabled.
This also reverts the change to hide the copy query button on the search homepage.
Test plan
Accessed search home page and results page locally.
App preview:
Check out the client app preview documentation to learn more.