Open in Editor: Add filter for short URL patterns + test#44475
Conversation
Bundle size report 📦
Look at the Statoscope report for a full comparison between the commits 9882089 and 0e68f41 or learn more. Open explanation
|
philipp-spiess
left a comment
There was a problem hiding this comment.
Nice!! The test suite is really paying off here to have confidence that we don't break other tested branches. 💯
I think the logic makes sense 👍
|
Maybe we want to add a change log entry for this though? |
|
@philipp-spiess Nice catch! The thing is, I've never added a changelog item before :embassarred_laugh: so it was totally not in my workflow. Added it now. |
Haha yes it's not something that's naturally to me yet either 😬 |
|
Looks good to me @vdavid thanks for the quick fix! |
I've done some digging, and I don't see a truly elegant solution that I could deliver before tomorrow's branch cut.
The solution in this PR is not elegant, but it solves the current customer issue, and I find it unlikely that it'd break other cases.
My findings:
repositoryPathPatternis not available on the front end (for a reason).repositoryPathPatternon the original URLs.repositoryPathPatternis a part of the code host connection settings (The config visible at/site-admin/external-services/{id}), and the whole thing is not accessible to the front end. This is expected because this raw information should probably be available for admins.repositoryPathPattern, we can't reliably determine how many pieces we should cut off from the URL.Test plan
I've added a new test that covers this case; the old test and the new one are all passing, so I think this should be fine.
App preview:
Check out the client app preview documentation to learn more.