Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

Add docs and changelog entry for executor secrets#44453

Merged
eseliger merged 3 commits into
mainfrom
es/secret-docs
Nov 16, 2022
Merged

Add docs and changelog entry for executor secrets#44453
eseliger merged 3 commits into
mainfrom
es/secret-docs

Conversation

@eseliger

@eseliger eseliger commented Nov 15, 2022

Copy link
Copy Markdown
Member

This is the last bit for executor secrets. I've added a section to the YAML reference and linked to a new page that explains secret namespacing and has sections how to create, update and remove secrets.

Closes https://github.com/sourcegraph/sourcegraph/issues/27926

Test plan

Docs.

App preview:

Check out the client app preview documentation to learn more.

This is the last bit for executor secrets. I've added a section to the YAML reference and linked to a new page that explains secret namespacing and has sections how to create, update and remove secrets.
@eseliger eseliger requested a review from a team November 15, 2022 22:56
@cla-bot cla-bot Bot added the cla-signed label Nov 15, 2022
@sourcegraph-bot

sourcegraph-bot commented Nov 15, 2022

Copy link
Copy Markdown
Contributor

Codenotify: Notifying subscribers in CODENOTIFY files for diff 167924f...989c8fc.

Notify File(s)
@courier-new client/web/src/enterprise/batches/list/BatchChangesChangelogAlert.tsx
doc/batch_changes/references/batch_spec_yaml_reference.md
@sourcegraph/delivery doc/admin/executor_secrets.md

@sg-e2e-regression-test-bob

sg-e2e-regression-test-bob commented Nov 15, 2022

Copy link
Copy Markdown

Bundle size report 📦

Initial size Total size Async size Modules
0.00% (0.00 kb) -0.00% (-0.26 kb) -0.00% (-0.26 kb) 0.00% (0)

Look at the Statoscope report for a full comparison between the commits 989c8fc and 167924f or learn more.

Open explanation
  • Initial size is the size of the initial bundle (the one that is loaded when you open the page)
  • Total size is the size of the initial bundle + all the async loaded chunks
  • Async size is the size of all the async loaded chunks
  • Modules is the number of modules in the initial bundle

Comment thread doc/admin/executor_secrets.md Outdated
eseliger and others added 2 commits November 16, 2022 01:17
Co-authored-by: Randell Callahan <piszmogcode@gmail.com>
@eseliger eseliger enabled auto-merge (squash) November 16, 2022 00:21
@eseliger eseliger merged commit 29bfe6e into main Nov 16, 2022
@eseliger eseliger deleted the es/secret-docs branch November 16, 2022 00:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

executors: Secret values

4 participants