Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

search: Force linting pass when query parsing changes due to external triggers#43849

Merged
fkling merged 2 commits into
mainfrom
fkling/43836-query-diagnostics
Nov 4, 2022
Merged

search: Force linting pass when query parsing changes due to external triggers#43849
fkling merged 2 commits into
mainfrom
fkling/43836-query-diagnostics

Conversation

@fkling

@fkling fkling commented Nov 3, 2022

Copy link
Copy Markdown
Contributor

Fixes #43836

This updates the CodeMirror query input to lint the input when the query parsing configuration has changed.

Test plan

Manually tested the uses cases mentioned in the issue.

App preview:

Check out the client app preview documentation to learn more.

… triggers

Fixes #43836

This updates the CodeMirror query input to lint the input when the query
parsing configuration has changed.
@fkling fkling added team/search-product Issues owned by the search product team codemirror PRs and issues related to migrating to CodeMirror labels Nov 3, 2022
@fkling fkling requested a review from a team November 3, 2022 09:07
@cla-bot cla-bot Bot added the cla-signed label Nov 3, 2022
@sourcegraph-bot

sourcegraph-bot commented Nov 3, 2022

Copy link
Copy Markdown
Contributor

Codenotify: Notifying subscribers in CODENOTIFY files for diff 67b12cf...222d415.

Notify File(s)
@limitedmage client/search-ui/src/input/CodeMirrorQueryInput.tsx

@sg-e2e-regression-test-bob

sg-e2e-regression-test-bob commented Nov 3, 2022

Copy link
Copy Markdown

Bundle size report 📦

Initial size Total size Async size Modules
0.00% (0.00 kb) 0.00% (+0.37 kb) 0.00% (+0.37 kb) 0.00% (0)

Look at the Statoscope report for a full comparison between the commits 222d415 and 4495a37 or learn more.

Open explanation
  • Initial size is the size of the initial bundle (the one that is loaded when you open the page)
  • Total size is the size of the initial bundle + all the async loaded chunks
  • Async size is the size of all the async loaded chunks
  • Modules is the number of modules in the initial bundle

@fkling fkling merged commit 9856399 into main Nov 4, 2022
@fkling fkling deleted the fkling/43836-query-diagnostics branch November 4, 2022 11:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed codemirror PRs and issues related to migrating to CodeMirror team/search-product Issues owned by the search product team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Query diagnostics not triggering after toggles are clicked

4 participants