This repository was archived by the owner on Sep 30, 2024. It is now read-only.
search frontend: warn on structural search without lang: filter#43835
Merged
Conversation
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff e711dd7...beaf3ee.
|
89f1dd3 to
f26cdd0
Compare
rvantonder
commented
Nov 2, 2022
Contributor
Author
There was a problem hiding this comment.
Just adding lang:go explicitly to these existing test so we can isolate the diagnostics being tested.
Bundle size report 📦
Look at the Statoscope report for a full comparison between the commits beaf3ee and 7b2e149 or learn more. Open explanation
|
camdencheek
approved these changes
Nov 3, 2022
camdencheek
left a comment
Member
There was a problem hiding this comment.
Nice, I've definitely been caught by this before
fkling
reviewed
Nov 3, 2022
fkling
approved these changes
Nov 3, 2022
f26cdd0 to
125174f
Compare
125174f to
4511198
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a warning diagnostic when structural search is active but
lang:is not set.When structural search is active users should add a
lang:filter so that we can pick the right parser. Iflang:isn't set, we may fall back to a generic parser, which can "miss" results that the user would normally expect.More context: https://sourcegraph.slack.com/archives/C07KZF47K/p1667385583731439
Test plan
Updated unit tests.
App preview:
Check out the client app preview documentation to learn more.