web: link to codehost when file is an LFS Pointer#43686
Conversation
This is a very minimal sketch of what we can add to our API to support indicating a file is an LFS pointer. When a file is stored in LFS this field will be non-nil.
ac62d88 to
750ddfb
Compare
|
@limitedmage I pushed a tiny update which makes the resolver pretend every file is in LFS. I didn't manage to do more than that today, but will try and make this end point functional tomorrow. If you have any feedback on the API, please go ahead. I can make any possible changes, this was designed very very quickly. |
Bundle size report 📦
Look at the Statoscope report for a full comparison between the commits dc50926 and 5c91557 or learn more. Open explanation
|
|
@keegancsmith I pushed a rudimentary-but-fully-featured UI for this. Let me know if you need anything else from the frontend! |
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 5c91557...dc50926. No notifications. |
limitedmage
left a comment
There was a problem hiding this comment.
Frontend and API look good to me. Please have someone else review the backend code :)
|
@stefanhengl or @ryanslade mind taking a look at the backend code? It's super simple, but luckily from reading the upstream implementations that is also simple :P I'm gonna push a commit now with a changelog entry. |
Co-authored-by: Erik Seliger <erikseliger@me.com>
We extend the GraphQL schema to optionally have a field LFS. This field is non-null when the content of the git blob is a LFS pointer. When it is we show a page linking to the code host. This was a request from a customer.
The actual git lfs project uses similiar heuristics, except it does expect the full document to be this KV style. Other projects such as gitlab just use regexes and file size like we do.
Test Plan: manually visited in dev server LFS pointer files.
Co-authored-by: @limitedmage