Upgrade git version to 2.38.1 in Gitserver and Server Docker Images#43615
Conversation
mollylogue
left a comment
There was a problem hiding this comment.
💯 this is the bug that was causing a lot of repo corruptions, right?
There were actually 2 bugs in play here: We tried to upgrade to 2.35.2 to get the fix for this bug: https://github.blog/2022-04-12-git-security-vulnerability-announced/ But that version of git had the commit-graph bug that caused the corruptions: https://lore.kernel.org/git/581c7ef2-3de4-eb8a-bfbb-d4bca3522a2d@github.com/T/ So we ended up reverting and going back to the old version, and now this should push us past both bugs, plus give us access to Scalar as an added bonus 😄. |
mrnugget
left a comment
There was a problem hiding this comment.
Can you also update these two places here?
- https://github.com/sourcegraph/sourcegraph/blob/1beba7d86196bf8db08cf33e90c518fa980b43e1/dev/sg/dependencies/mac.go#L39
- https://github.com/sourcegraph/sourcegraph/blob/1beba7d86196bf8db08cf33e90c518fa980b43e1/dev/sg/dependencies/ubuntu.go#L36
Once that's done and this is merged, can you post in #dev-chat that folks need to upgrade their git versions locally?
sashaostrikov
left a comment
There was a problem hiding this comment.
Agree with Thorsten's comments, apart from that LGTM brat
Sounds good, addressed in most recent commit. |
|
Codenotify: Notifying subscribers in OWNERS files for diff 5e962fe...0bad536.
|
Upgrade git to version 2.38.1
We previously had it upgraded to min 2.35.2 here, but that had a bug with the git commit-graph command, so we reverted it here
The new version of git resolves the bug above so we can safely upgrade again.
Test plan
Just a version change, built the container locally and verified the version