move legacy codeintel to enterprise#43578
Conversation
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff d817791...521e465.
|
Fixes:
```
TypeError: Cannot read properties of undefined (reading 'fields')
at API.hasStencils (api.ts:579:84)
```
Related to https://github.com/sourcegraph/sourcegraph/pull/43458, but that did not fully fix the issue (seemingly because the GitBlobLSIFData type is not even introspectible on OSS because LSIF is not available in OSS).
b672b3d to
506523c
Compare
Bundle size report 📦
Look at the Statoscope report for a full comparison between the commits 521e465 and 524e11d or learn more. Open explanation
|
506523c to
8d89e9a
Compare
The search-based code intelligence is an enterprise-only feature. This change clarifies it by showing a nicer message instead of an error if it's attempted to be used in the OSS build. It also cleans up how the enabled-or-not flag is determined in code.
8d89e9a to
521e465
Compare
olafurpg
left a comment
There was a problem hiding this comment.
LGTM to unblock merge 👍🏻
Is it expected that the popover still shows an error here?
|
Ideally, we disable the injection of the legacy extension API around this file here https://sourcegraph.com/github.com/sourcegraph/sourcegraph/-/blob/client/shared/src/extensions/createNoopLoadedController.ts?L23 |
|
@olafurpg Yes, I did not go so far to fix that. It basically swaps out one error for another error. |
|
What is the best way to detect that we're running OSS? As long as we have a boolean setting we can disable the injection |
|
@olafurpg there's a |
The search-based code intelligence is an enterprise-only feature. This change clarifies it by showing a nicer message instead of an error if it's attempted to be used in the OSS build. It also cleans up how the enabled-or-not flag is determined in code.
Also cleans up other things related to code nav when running in OSS.
Test plan
Confirm the "unavailable" message shows up in OSS:
Confirm the references panel still works in non-OSS:
App preview:
Check out the client app preview documentation to learn more.