Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

web: fix navbar in oss version showing non-oss features#43450

Merged
limitedmage merged 5 commits into
mainfrom
jp/ossnavbar
Oct 27, 2022
Merged

web: fix navbar in oss version showing non-oss features#43450
limitedmage merged 5 commits into
mainfrom
jp/ossnavbar

Conversation

@limitedmage

@limitedmage limitedmage commented Oct 25, 2022 •
edited by sourcegraph-bot
Loading

Copy link
Copy Markdown
Contributor

Closes #43299
Closes #43300

Some features, including Notebooks, Code Monitoring and Search Contexts, are enterprise-only but weren't properly removed in the web UI. Some of them are completely non-functional (no routes) and some open but don't load anything. This PR fixes all of those.

  • Removes Notebooks and Code Monitoring from navbar if on OSS
  • Removes empty dropdown where Search Contexts is supposed to be if on OSS
  • Moves Notebooks routes with the rest of the enterprise routes (routes no longer work on OSS)

Test plan

  • No changes should happen to the full enterprise version of Sourcegraph. Notebooks, code monitoring, and contexts should continue to work as intended and appear in the navbar.
  • In the OSS version, by running sg start oss, test the navbar and notebooks routes. Also verify that .snb.md files continue to render as normal.

App preview:

Check out the client app preview documentation to learn more.

@cla-bot cla-bot Bot added the cla-signed label Oct 25, 2022
@sg-e2e-regression-test-bob

sg-e2e-regression-test-bob commented Oct 25, 2022 •
edited
Loading

Copy link
Copy Markdown

Bundle size report 📦

Initial size Total size Async size Modules
0.01% (+0.20 kb) 0.00% (+0.20 kb) 0.00% (0.00 kb) 0.00% (0)

Look at the Statoscope report for a full comparison between the commits 33f5bdd and 99d011e or learn more.

Open explanation
  • Initial size is the size of the initial bundle (the one that is loaded when you open the page)
  • Total size is the size of the initial bundle + all the async loaded chunks
  • Async size is the size of all the async loaded chunks
  • Modules is the number of modules in the initial bundle

@limitedmage limitedmage mentioned this pull request Oct 26, 2022
Merged
@limitedmage limitedmage marked this pull request as ready for review October 26, 2022 20:27
@limitedmage limitedmage requested review from a team and novoselrok October 26, 2022 20:27
@limitedmage limitedmage merged commit 56ab377 into main Oct 27, 2022
@limitedmage limitedmage deleted the jp/ossnavbar branch October 27, 2022 19:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@novoselrok novoselrok novoselrok approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla-signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Notebooks not working in Sourcegraph OSS Search Contexts not working on Sourcegraph OSS

3 participants

@limitedmage @sg-e2e-regression-test-bob @novoselrok