This repository was archived by the owner on Sep 30, 2024. It is now read-only.
search: content filter implies searching only file content#43442
Merged
Conversation
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 12a6727...b2d3ff7.
|
1267920 to
71ab402
Compare
tbliu98
approved these changes
Oct 25, 2022
0584f1c to
65243e6
Compare
Base automatically changed from
backend-integration/rvt/content-filter-2
to
main
October 25, 2022 21:20
a0d7efb to
8a5dca3
Compare
8a5dca3 to
b2d3ff7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a query specifies
content:explicitly then we'll search only content if notypeis set (previously we would search path, repo, and content, sincecontent:was treated as if it were a pattern). This was a paper cut from a while ago, and more recently in feedback https://sourcegraph.slack.com/archives/C03CSAER9LK/p1666369025491439This is a small change in behavior, if users previously relied on
content:"path with spaces"to try and search for paths without usingpath, they will no longer see results (but that was a confusing/buggy/unintended behavior anyway, so the meaning is now more clear withcontent).Test plan
Added tests.