This repository was archived by the owner on Sep 30, 2024. It is now read-only.
search ui: highlight path matches for files in root directory#43275
Merged
Conversation
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 558139b...966e481.
|
Bundle size report 📦
Look at the Statoscope report for a full comparison between the commits 966e481 and 0a58068 or learn more. Open explanation
|
novoselrok
approved these changes
Oct 21, 2022
limitedmage
reviewed
Oct 21, 2022
limitedmage
left a comment
Contributor
There was a problem hiding this comment.
Nice! Should we add a changelog entry for this?
Merged
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug where path matches on files in the root directory of a repository were not highlighted.
fileBaseis empty for file paths in the root directory and so theifcondition inuseEffect()would evaluate to false and highlighting would not happen.Test plan
Manual testing
Before:
After:
App preview:
Check out the client app preview documentation to learn more.