This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Remove LOG_ALL_GRAPHQL_REQUESTS env var.#43181
Merged
Merged
Conversation
This is succeeded by `log.auditLog.graphQl` site config setting.
willdollman
approved these changes
Oct 19, 2022
rafax
approved these changes
Oct 24, 2022
Contributor
There was a problem hiding this comment.
Change LGTM, not sure if LOG_ALL_GRAPHQL_REQUESTS is still used by customers?
If so, would it make sense to leave a "you set LOG_ALL_GRAPHQL_REQUESTS, which was replaced by log.auditLog.graphQL" warning / panic (cost to maintainability of our code is minimal, but it can prevent surprises when customers no longer get audit logs)?
Contributor
Author
|
I talked w/ the team regarding how risky "simply dropping the var" is, and we agreed we'll go for it.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove
LOG_ALL_GRAPHQL_REQUESTSenv var. This is succeeded bylog.auditLog.graphQLsite config setting.Test plan