Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

insights: augment series points with zero values#43166

Merged
leonore merged 81 commits into
mainfrom
insights/augment-points-in-memory
Oct 25, 2022
Merged

insights: augment series points with zero values#43166
leonore merged 81 commits into
mainfrom
insights/augment-points-in-memory

Conversation

@leonore

@leonore leonore commented Oct 19, 2022

Copy link
Copy Markdown
Contributor

closes #42345

Test plan

Add unit test for augment function

Manually tested/compared with s2

before after
Screenshot 2022-10-19 at 12 45 09 Screenshot 2022-10-19 at 12 45 11

leo added 30 commits September 26, 2022 15:27
@leonore leonore force-pushed the insights/augment-points-in-memory branch from 314a03d to ba3a63d Compare October 24, 2022 12:56
Comment thread enterprise/internal/insights/resolvers/insight_series_resolver.go
Comment thread CHANGELOG.md Outdated

@coury-clark coury-clark left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So happy to have this land!

Comment thread enterprise/internal/insights/resolvers/insight_series_resolver.go Outdated
Comment thread enterprise/internal/insights/resolvers/insight_series_resolver.go Outdated
Comment thread enterprise/internal/insights/resolvers/insight_series_resolver.go Outdated
@leonore leonore requested a review from coury-clark October 24, 2022 17:49
Comment thread internal/database/schema.md
Comment thread enterprise/internal/insights/store/insight_store.go Outdated
Comment thread migrations/codeinsights/squashed.sql Outdated
@leonore leonore marked this pull request as draft October 25, 2022 09:48
@leonore leonore force-pushed the insights/augment-points-in-memory branch from 778161b to ed565ec Compare October 25, 2022 09:54
@leonore leonore marked this pull request as ready for review October 25, 2022 09:55
@leonore leonore merged commit 79b915a into main Oct 25, 2022
@leonore leonore deleted the insights/augment-points-in-memory branch October 25, 2022 11:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

insights: use recording times interval data to augment insight series with missing data points

5 participants