Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

Revert search result component changes#42965

Merged
novoselrok merged 2 commits into
mainfrom
rn/revert-search-result-component-changes
Oct 14, 2022
Merged

Revert search result component changes#42965
novoselrok merged 2 commits into
mainfrom
rn/revert-search-result-component-changes

Conversation

@novoselrok

@novoselrok novoselrok commented Oct 14, 2022

Copy link
Copy Markdown
Contributor

Revert changes from https://github.com/sourcegraph/sourcegraph/pull/42483 and https://github.com/sourcegraph/sourcegraph/pull/42721 because they break the VSCode extension.

Test plan

  • VSCode extension should work.

App preview:

Check out the client app preview documentation to learn more.

@novoselrok novoselrok requested a review from a team October 14, 2022 06:08
@cla-bot cla-bot Bot added the cla-signed label Oct 14, 2022
@sourcegraph-bot

Copy link
Copy Markdown
Contributor

Codenotify: Notifying subscribers in CODENOTIFY files for diff 1926550...3462356.

Notify File(s)
@fkling client/search-ui/src/components/CodeExcerpt.tsx
client/search-ui/src/components/CommitSearchResult.tsx
client/search-ui/src/components/FileContentSearchResult.test.tsx
client/search-ui/src/components/FileContentSearchResult.tsx
client/search-ui/src/components/FileMatchChildren.module.scss
client/search-ui/src/components/FileMatchChildren.tsx
client/search-ui/src/components/FilePathSearchResult.tsx
client/search-ui/src/components/FileSearchResult.test.tsx
client/search-ui/src/components/FileSearchResult.tsx
client/search-ui/src/components/LegacyResultContainer.module.scss
client/search-ui/src/components/LegacyResultContainer.tsx
client/search-ui/src/components/RepoFileLink.tsx
client/search-ui/src/components/RepoSearchResult.tsx
client/search-ui/src/components/ResultContainer.module.scss
client/search-ui/src/components/ResultContainer.test.tsx
client/search-ui/src/components/ResultContainer.tsx
client/search-ui/src/components/SearchResult.module.scss
client/search-ui/src/components/SymbolSearchResult.module.scss
client/search-ui/src/components/SymbolSearchResult.tsx
client/search-ui/src/components/snapshots/RepoFileLink.test.tsx.snap
client/search-ui/src/components/codeLinkNavigation.ts
client/search-ui/src/components/index.ts
client/search-ui/src/results/StreamingSearchResultsList.tsx
client/web/src/search/results/StreamingSearchResults.test.tsx
@limitedmage client/search-ui/src/components/CodeExcerpt.tsx
client/search-ui/src/components/CommitSearchResult.tsx
client/search-ui/src/components/FileContentSearchResult.test.tsx
client/search-ui/src/components/FileContentSearchResult.tsx
client/search-ui/src/components/FileMatchChildren.module.scss
client/search-ui/src/components/FileMatchChildren.tsx
client/search-ui/src/components/FilePathSearchResult.tsx
client/search-ui/src/components/FileSearchResult.test.tsx
client/search-ui/src/components/FileSearchResult.tsx
client/search-ui/src/components/LegacyResultContainer.module.scss
client/search-ui/src/components/LegacyResultContainer.tsx
client/search-ui/src/components/RepoFileLink.tsx
client/search-ui/src/components/RepoSearchResult.tsx
client/search-ui/src/components/ResultContainer.module.scss
client/search-ui/src/components/ResultContainer.test.tsx
client/search-ui/src/components/ResultContainer.tsx
client/search-ui/src/components/SearchResult.module.scss
client/search-ui/src/components/SymbolSearchResult.module.scss
client/search-ui/src/components/SymbolSearchResult.tsx
client/search-ui/src/components/snapshots/RepoFileLink.test.tsx.snap
client/search-ui/src/components/codeLinkNavigation.ts
client/search-ui/src/components/index.ts
client/search-ui/src/results/StreamingSearchResultsList.tsx
client/web/src/integration/search.test.ts
client/web/src/search/results/StreamingSearchResults.test.tsx

@sg-e2e-regression-test-bob

Copy link
Copy Markdown

Bundle size report 📦

Initial size Total size Async size Modules
0.10% (+3.00 kb) 0.03% (+3.90 kb) 0.01% (+0.90 kb) 0.14% (+1) 🔺

Look at the Statoscope report for a full comparison between the commits 3462356 and 1926550 or learn more.

Open explanation
  • Initial size is the size of the initial bundle (the one that is loaded when you open the page)
  • Total size is the size of the initial bundle + all the async loaded chunks
  • Async size is the size of all the async loaded chunks
  • Modules is the number of modules in the initial bundle

@novoselrok novoselrok merged commit 8bb1825 into main Oct 14, 2022
@novoselrok novoselrok deleted the rn/revert-search-result-component-changes branch October 14, 2022 06:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants