This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Audit log: Optionally mute background jobs (internal actors). #42946
Merged
Conversation
…s to false. Audit log: Add audit.IsEnabled function to avoid repeating the same logic.
bobheadxi
reviewed
Oct 13, 2022
Comment on lines
+22
to
25
| // internal actors add a lot of noise to the audit log | ||
| if act.Internal && !IsEnabled(conf.SiteConfig(), BackgroundJobs) { | ||
| return | ||
| } |
Member
There was a problem hiding this comment.
IIRC it's not just background jobs that uses internal actors right? Maybe InternalTraffic is a more apt "abstraction" for the configuration?
mrnugget
approved these changes
Oct 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Site admins can now optionally enable detailed (noisy) audit logs for the background jobs. For the sake of simplicity, any action that uses internal actor will be considered a "background job" in the audit log context.
The default value is
false.This PR also refactors the
auditLogEnabledlogic, which has been repeated at a few places, and groups that logic into a single location, accessible viaaudit.IsEnabled(cfg, setting)function.Test plan