This repository was archived by the owner on Sep 30, 2024. It is now read-only.
remove key field from codehost json field#42838
Merged
Merged
Conversation
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 24c2ab1...d7d606e.
|
akalia25
approved these changes
Oct 11, 2022
akalia25
left a comment
Contributor
There was a problem hiding this comment.
Thanks for reverting this change!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
#42024 added an extra field to the Version struct for external services, this field is used merely as an identifier to recognize different GitLab versions. This struct was used to send ping data for
code_host_versionsand theKeyfield was sent as part of the ping payload (which shouldn't be).This PR ensures the field isn't being sent when we marshal the versions for sending pings.
Test plan
Check the
code_host_versionsping data and confirm the field isn't being sent.