This repository was archived by the owner on Sep 30, 2024. It is now read-only.
insights: save insight series recording times on creation and job runs#42801
Merged
Conversation
added 14 commits
September 26, 2022 15:27
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff dfe0ab9...f8c4124.
|
added 2 commits
October 12, 2022 18:24
chwarwick
reviewed
Oct 12, 2022
coury-clark
reviewed
Oct 13, 2022
added 16 commits
October 14, 2022 11:20
chwarwick
reviewed
Oct 17, 2022
chwarwick
left a comment
Contributor
There was a problem hiding this comment.
I think it looks good, but I think you are missing the dependent frames times and possibly preempted repos in all repos backfilling.
chwarwick
reviewed
Oct 18, 2022
chwarwick
left a comment
Contributor
There was a problem hiding this comment.
I think you've got everything covered here. I'm just not sure if it dependent on the the snapshot item too.
chwarwick
approved these changes
Oct 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #42343 but should not be merged before all the other issues are worked on in case the db schema needs to be changed or things need to be polished
Test plan
Added unit tests. Have manually tested the logic
explanatory loom: https://www.loom.com/share/080da2d41ba349278b35c1557dca4deb