Add optional switch for disabling custom git fetch#42704
Conversation
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 7b7e3a9...8c1ced0.
|
daxmc99
left a comment
There was a problem hiding this comment.
This also needs to be mentioned in our CHANGELOG.md file
DaedalusG
left a comment
There was a problem hiding this comment.
This is a much better approach than mounting a json file with the repo to fetch mapping 👍
I do agree with Dax, probably better to have it disabled by default. Branched and switched the booleans -- PR: https://github.com/sourcegraph/sourcegraph/pull/42723
DaedalusG
left a comment
There was a problem hiding this comment.
If this has been tested manually, I think it should be good to ship 👍
daxmc99
left a comment
There was a problem hiding this comment.
LGTM, I'll defer to @DaedalusG to get customer feedback on this. We should inform them of this change prior to the release so they aren't blindsided
e3292f4 to
8e2d196
Compare
daxmc99
left a comment
There was a problem hiding this comment.
LGTM! This approach makes sense.
One last note is that the large diff here seems to be due to some auto-formatting running over the JSON. Might want to regen the schema again to avoid this.
* switch to enable rather than disable env var * add changelog entry Co-authored-by: Vincent Ruijter <vincent.ruijter@sourcegraph.com>
d833d5c to
8c1ced0
Compare
Disable custom git fetch through an environment variable
Test plan