This repository was archived by the owner on Sep 30, 2024. It is now read-only.
search ui: FileSearchResult refactor#42631
Merged
novoselrok merged 7 commits intoOct 10, 2022
Merged
Conversation
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff e7a50d0...3d7622d.
|
limitedmage
approved these changes
Oct 7, 2022
| } | ||
| } | ||
|
|
||
| .header-description { |
Contributor
There was a problem hiding this comment.
Do these styles have to be removed from ResultContainer.module.scss? (I'm not seeing that file in this PR?)
| </Component> | ||
| ) | ||
| } | ||
| }) as ForwardReferenceExoticComponent<React.ElementType, React.PropsWithChildren<ResultContainerProps>> |
Contributor
There was a problem hiding this comment.
minor: can we move the type definition next to the variable declaration (eg. export const ResultContainer: ForwardReferenceExoticComponent<React.ElementType, React.PropsWithChildren<ResultContainerProps>> = ...) if it's for sure needed?
added 2 commits
October 10, 2022 07:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of https://github.com/sourcegraph/sourcegraph/issues/42159
Summary
hunkssupport on the clientTest plan
App preview:
Check out the client app preview documentation to learn more.