This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Make GraphQL logs an optional part of the audit logs. (take 2)#42550
Merged
Conversation
rafax
reviewed
Oct 6, 2022
rafax
approved these changes
Oct 6, 2022
bobheadxi
approved these changes
Oct 6, 2022
bobheadxi
left a comment
Member
There was a problem hiding this comment.
nice, other than minor nits - thanks for the testing as well!
Co-authored-by: Robert Lin <robert@bobheadxi.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
GraphQL logs will optionally be included in the audit log.
Further details in RFC 734.
Implementation details
This is another take on the work done in https://github.com/sourcegraph/sourcegraph/pull/41952
The audit logs are (optionally) recorded in the serveGraphQL function. This is a better place to host the logic as:
The previous approach with
LOG_ALL_GRAPHQL_REQUESTSis left intact and scheduled for removal.Enabling the audit log
Sample audit log
Test plan