This repository was archived by the owner on Sep 30, 2024. It is now read-only.
authz/perforce: add additional unit test cases#42287
Merged
sashaostrikov merged 2 commits intoSep 29, 2022
Merged
Conversation
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 7d3ab17...097276c.
|
mollylogue
reviewed
Sep 29, 2022
| =read user alice * -//Sourcegraph/Engineering/Frontend/... ## exact match of a previous include | ||
| open user alice * -//Sourcegraph/Engineering/Backend/Credentials/... ## sub-match of a previous include | ||
| open user alice * -//Sourcegraph/Engineering/*/Frontend/Folder/... ## sub-match of a previous include | ||
| open user alice * -//Sourcegraph/*/Handbook/... ## sub-match of wildcard A include |
Contributor
There was a problem hiding this comment.
The comments here are super helpful 🙏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding some test cases.
Initial intention was to also add tests from manual testing doc, but our current unit test setup cannot support such e2e tests.
Closes https://github.com/sourcegraph/sourcegraph/issues/42156
Test plan
New tests added