Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

batches: HTTP API Monitoring#42251

Merged
Piszmog merged 2 commits into
mainfrom
rc/batches-httpapi-metrics
Oct 4, 2022
Merged

batches: HTTP API Monitoring#42251
Piszmog merged 2 commits into
mainfrom
rc/batches-httpapi-metrics

Conversation

@Piszmog

@Piszmog Piszmog commented Sep 28, 2022

Copy link
Copy Markdown
Contributor

Closes #41525.

Created a new observation group, added group to frontend monitoring definitions, and generated a new dashboards.md.

Test plan

No tests to add.

@Piszmog Piszmog requested a review from a team September 28, 2022 15:01
@cla-bot cla-bot Bot added the cla-signed label Sep 28, 2022
@sourcegraph-bot

sourcegraph-bot commented Sep 28, 2022

Copy link
Copy Markdown
Contributor

Codenotify: Notifying subscribers in CODENOTIFY files for diff 6271369...e0a2bb3.

Notify File(s)
@bobheadxi monitoring/definitions/frontend.go
monitoring/definitions/shared/batches.go
@slimsag monitoring/definitions/frontend.go
monitoring/definitions/shared/batches.go
@sourcegraph/delivery doc/admin/observability/dashboards.md
monitoring/definitions/frontend.go
monitoring/definitions/shared/batches.go

@eseliger eseliger left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Damn sorry I missed this. Thanks for doing this!

@Piszmog Piszmog enabled auto-merge (squash) October 4, 2022 16:23
@Piszmog Piszmog merged commit 237d585 into main Oct 4, 2022
@Piszmog Piszmog deleted the rc/batches-httpapi-metrics branch October 4, 2022 16:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Batches File Handler Metrics to Grafana Dashboard

4 participants