Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

Perforce: Remove all references to PathIncludes and PathExcludes#41994

Merged
pjlast merged 2 commits into
pjlast/41788-perforce-permissions-use-paths-columnfrom
pjlast/41992-perforce-remove-all-references-to-pathincludes-and-pathexcludes
Sep 23, 2022
Merged

Perforce: Remove all references to PathIncludes and PathExcludes#41994
pjlast merged 2 commits into
pjlast/41788-perforce-permissions-use-paths-columnfrom
pjlast/41992-perforce-remove-all-references-to-pathincludes-and-pathexcludes

Conversation

@pjlast

@pjlast pjlast commented Sep 23, 2022

Copy link
Copy Markdown
Contributor

Solves #41992

Removes all references to PathIncludes and PathExcludes from the code. This prevents them from sneaking in unexpectedly and relying on old behaviours.

The DB columns remain untouched for now in case a rollback is required.

Test plan

Test updates

@pjlast pjlast requested review from a team, ryanslade and sashaostrikov September 23, 2022 10:27
@pjlast pjlast self-assigned this Sep 23, 2022
@cla-bot cla-bot Bot added the cla-signed label Sep 23, 2022
@pjlast pjlast linked an issue Sep 23, 2022 that may be closed by this pull request
@pjlast pjlast changed the title Remove all references to PathIncludes and PathExcludes Perforce: Remove all references to PathIncludes and PathExcludes Sep 23, 2022
@sourcegraph-bot

sourcegraph-bot commented Sep 23, 2022

Copy link
Copy Markdown
Contributor

Codenotify: Notifying subscribers in CODENOTIFY files for diff 28fe4fe...0e3df2b.

Notify File(s)
@indradhanush enterprise/cmd/repo-updater/internal/authz/perms_syncer_test.go
@unknwon enterprise/cmd/frontend/internal/authz/resolvers/resolver.go
enterprise/cmd/repo-updater/internal/authz/perms_syncer_test.go
internal/authz/iface.go
internal/authz/sub_repo_perms_test.go

@kopancek kopancek left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

…o pjlast/41992-perforce-remove-all-references-to-pathincludes-and-pathexcludes
@pjlast pjlast merged commit c0d4451 into pjlast/41788-perforce-permissions-use-paths-column Sep 23, 2022
@pjlast pjlast deleted the pjlast/41992-perforce-remove-all-references-to-pathincludes-and-pathexcludes branch September 23, 2022 13:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Perforce: Remove all references to PathIncludes and PathExcludes

4 participants