This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Performance: Prefetch file blobs from search results#41420
Merged
Conversation
umpox
commented
Sep 7, 2022
| } | ||
| isSelected={isSelected} | ||
| revision={commitID} | ||
| revision={revision} |
Contributor
Author
There was a problem hiding this comment.
Note: This fixes a bug where the sidebar prefetch logic wasn't being used correctly, as we no longer rely on the resolvedRev for the commitID (we use the URL as a source of truth instead, and let the backend resolve it)
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 5d198e4...ca1ac39.
|
| * | ||
| * Note: This format should match the format used when the blob is 'normally' fetched. E.g. in `BlobPage.tsx`. | ||
| */ | ||
| export const usePrefetchBlobFormat = (): HighlightResponseFormat => { |
This was referenced Sep 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for prefetching blobs from the search results through hover or focus, through the experimental feature
enableSearchFilePrefetchThis should significantly speed up time from search results -> viewing code, especially now we have no waterfall logic between these components
Before
PrefetchSearchBefore8Sept.mp4
After
PrefetchSearchAfter8Sept.mp4
Test plan
Tested locally with different configurations of highlighting / file viewer