This repository was archived by the owner on Sep 30, 2024. It is now read-only.
search: highlight matching path ranges on content matches#41385
Merged
Conversation
1c3477a to
2b6a03d
Compare
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff c49a3aa...e77b7d9.
|
camdencheek
approved these changes
Sep 6, 2022
camdencheek
left a comment
Member
There was a problem hiding this comment.
Woah, much smaller change than I expected 😄
Base automatically changed from
tl/distinguish-file-content-match-from-path-match
to
main
September 6, 2022 21:30
4d94daf to
a62e5e3
Compare
a62e5e3 to
e77b7d9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #41297
Part of #18374
Per feedback, this PR adds file path highlighting to content matches.
Test plan
Visually verify highlighting is occurring
CI